Repository navigation
Conversation
|
@mlouielu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbkaiser, @terryjreedy and @ned-deily to be potential reviewers. |
|
I'm wondering about the naming of the function "user_interrupt". The other "user_*" functions ("user_line", "user_exception", etc.) are Bdb callbacks that allow the debugger to update itself based on the current state of the running program. In this case, we're actually trying to control the running program, and this routine is called by our own code, not Bdb. The Bdb "set_" functions do control the running program, so we could consider "set_interrupt". The only potential downside is that it wouldn't be clear that this isn't a Bdb function. Perhaps something along the lines of "force_interrupt"? I'm not normally super-pendantic about names, but with all the difference places where code is running in the debugger, it's hard enough to follow as it is, so anything that can be done in IDLE to avoid confusion is a good thing. |
|
This PR is stale because it has been open for 30 days with no activity. |
|
This PR is stale because it has been open for 30 days with no activity. |
iritkatriel
left a comment
There was a problem hiding this comment.
This has merge conflicts now.
|
This PR is stale because it has been open for 30 days with no activity. |
|
This PR is stale because it has been open for 30 days with no activity. |
|
This PR has been open since 2017 with no human activity in years, conflicts in Lib/idlelib/debugger.py and run.py, and its bdb/RPC-level behavior change never got IDLE maintainer review. Closing to cull the number of open pull requests. Do not reopen this pull request without getting a go-ahead from a triager or core developer on gh-58319. |
Patch by: Roger Serwy
https://bugs.python.org/issue14111